Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache EndpointConfig session #12886

Merged
merged 11 commits into from Oct 5, 2023

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Oct 3, 2023

Proposed changes:

  • Fixes ATO-1646
  • Had to pin ddtrace in the CI workflows because the new version 2.0.0 released on Tue 3rd Oct upgrades wrapt to 1.15 and uninstalls Tensorflow's constraint to be pinned at <1.15, this causes 30 job failures.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita added the tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests label Oct 4, 2023
@ancalita ancalita removed the tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests label Oct 4, 2023
@ancalita ancalita changed the title Cache session property of endpoint config Cache EndpointConfig session Oct 4, 2023
@ancalita ancalita marked this pull request as ready for review October 4, 2023 10:38
@ancalita ancalita requested review from a team as code owners October 4, 2023 10:38
@ancalita ancalita requested review from miraai, souvikg10, a team and radovanZRasa and removed request for a team October 4, 2023 10:38

- name: Install ddtrace on Windows
if: needs.changes.outputs.backend == 'true' && matrix.os == 'windows-2019'
run: py -m pip install -U 'ddtrace<2.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miraai Is there a unified command provided by Github actions that allows us to install a dependency with a constraint for both OS types?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ancalita We can use RUNNER_OS envar to put this into a single step, your call though if it is worth it

- name:  Install ddtrace
  if: needs.changes.outputs.backend == 'true'
  run:   |
         if [ "$RUNNER_OS" == "Linux" ]; then
              poetry run pip install -U 'ddtrace<2.0.0'
         elif [ "$RUNNER_OS" == "Windows" ]; then
              py -m pip install -U 'ddtrace<2.0.0'
         else
              echo "$RUNNER_OS not supported"
              exit 1
         fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm not sure if matrix.os == runner.os

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miraai what approach do you recommend?

rasa/utils/endpoints.py Outdated Show resolved Hide resolved
@ancalita ancalita requested review from vcidst and removed request for radovanZRasa October 4, 2023 10:46
rasa/core/run.py Outdated Show resolved Hide resolved
Copy link
Contributor

@souvikg10 souvikg10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

🚀 A preview of the docs have been deployed at the following URL: https://12886--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@ancalita ancalita merged commit 7717472 into 3.6.x Oct 5, 2023
99 checks passed
@ancalita ancalita deleted the ATO-1646-rasa-action-server-connection-choking branch October 5, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants