Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated continue training #4990

Merged
merged 2 commits into from
Dec 18, 2019
Merged

deprecated continue training #4990

merged 2 commits into from
Dec 18, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Dec 18, 2019 •
edited
Loading

Proposed changes:

  • deprecated agent.continue_training it is not used anywhere, not even for interactive learning.

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested a review from Ghostvv December 18, 2019 10:59
@tmbo tmbo added this to the Rasa 1.6 milestone Dec 18, 2019
Ghostvv
Ghostvv approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@Ghostvv Ghostvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove continue training from all the core policies?

@tmbo
Copy link
Member Author

tmbo commented Dec 18, 2019

Yes I think so, will create a PR in a second - but would rather do that as part of the next minor after deprecating it properly.

@tmbo tmbo merged commit 275581f into master Dec 18, 2019
@tmbo tmbo deleted the remove-continue-training branch December 18, 2019 11:11
@tmbo tmbo mentioned this pull request Dec 18, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostvv Ghostvv Ghostvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Rasa 1.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmbo @Ghostvv