add --num-threads argument to train cli
#5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for submitting this PR, we'll give it a review as soon as possible |
tabergma
requested changes
Jan 20, 2020
There was a problem hiding this comment.
Looks good so far 👍, however a couple of things are missing:
- The tests are failing, please fix them (see https://github.com/RasaHQ/rasa/blob/master/tests/cli/test_rasa_train.py).
- Please add a changelog entry (see https://github.com/RasaHQ/rasa/tree/master/changelog)
- Your branch is not up-to-date, please update
mludv
force-pushed
the
add_num_threads_cli_argument
branch
2 times, most recently
from
0474812
to
806822d
Compare
mludv
force-pushed
the
add_num_threads_cli_argument
branch
from
806822d
to
d0268a9
Compare
|
|
|
@mludv Are you still working on this? If yes, would be great if you could tackle my comments. Would be great if we can merge this soon. Thanks! |
|
Hi Tanja, |
tmbo
reviewed
May 15, 2020
tabergma
approved these changes
May 18, 2020
indam23
pushed a commit
that referenced
this pull request
Jul 27, 2022
* add `--num-threads` argument to train cli * Update rasa/cli/train.py * Create 5086.feature.rst * fixed tests Co-authored-by: Tom Bocklisch <tom@rasa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I did some work on issue #4141
Take a look and say what you think
Proposed changes:
--num-threadscli arguments is added and forwarded to thekwargsof the NLU componentstrainmethod.Status (please check what you already did):
black(please check Readme for instructions)