Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event brokers documentation should say 'url' instead of 'host' #5811

Merged
merged 5 commits into from
May 18, 2020

Conversation

cristianmtr
Copy link
Contributor

Proposed changes:

  • event brokers documentation should say 'url' instead of 'host'. Otherwise it fails saying there are two arguments being passed for host.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented May 13, 2020

CLA assistant check
All committers have signed the CLA.

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @alwx will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from alwx May 14, 2020 11:16
@alwx alwx self-requested a review May 18, 2020 07:35
@alwx
Copy link
Contributor

alwx commented May 18, 2020

Hey @cristianmtr! Thanks for your contribution!
Could you also add a changelog entry? A file named changelog/5811.docs.rst with a one-line description of what this task is about (there is a template in changelog directory).

@cristianmtr
Copy link
Contributor Author

Hey @cristianmtr! Thanks for your contribution!
Could you also add a changelog entry? A file named changelog/5811.docs.rst with a one-line description of what this task is about (there is a template in changelog directory).

Done

@tmbo tmbo merged commit 1f58942 into RasaHQ:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants