New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docs: include source files #6199
Comments
I think we can reduce this to the minimum and really only include complete files. In most locations, this should be fine (or alternatively even add a simpler example to the docs). I'd really only go with complete includes for now and rather rework the docs to avoid using line or object based includes (e.g. most of them are in the events section, which doesn't make sense anyways - since users are using events from rasa-sdk and not from rasa open source) |
yes, fine by me. @erohmensing do you think that what @tmbo is easily doable? We might need your input to rework the content :) |
Sure, we can probably handle that. In fact it might help us make our code a little cleaner, and will make sure that the user always has the necessary imports to use any code referenced. Looks like the Other than that, would be helpful for the If that sounds good I'm happy to take on the content side of these changes -- if you assign me to a PR you make to do the backend changes for the existing includes, I can update these pages on there 👍 |
great, thanks @erohmensing ! |
⬆️ Relates to RasaHQ/growth#1436
We need to support the previous
.. literalinclude::
directives. We can useremark-sources
and manually replace (it cannot be done by the rst-to-markdown converter because sphinx loads the source file long before it's handed to the converter).💡 We are dropping support for "parts" of a file (for instance see
:start-after:
or:pyobject:
options). This will require some documentation work.Implementation proposal
What I think we can do (similarly to what we did with
variables.json
):mdx
filesdocs/sources
folder (for instance)docs/sources
folder (or the original path). We could forkremark-sources
and do that.That way it would work both in dev and in production (where there are multiple versions). The key is to keep things under the
docs
folder.The text was updated successfully, but these errors were encountered: