rasa test core: check if model was provided #6929
Conversation
| "No model provided. Please make sure to specify the model to test with '--model'." | ||
| ) | ||
| return | ||
|
|
||
| if isinstance(args.model, str): | ||
| model_path = rasa.cli.utils.get_validated_path( | ||
| args.model, "model", DEFAULT_MODELS_PATH |
There was a problem hiding this comment.
The default value doesn't make sense then, does it?
There was a problem hiding this comment.
It does. The errors happens if args.model = [None].
There was a problem hiding this comment.
but [None] already means that there is no model in the DEFAULT_MODELS_PATH, no?
There was a problem hiding this comment.
No. The default value of --model for rasa test core is set to the following: https://github.com/RasaHQ/rasa/blob/master/rasa/cli/arguments/test.py#L155
In case there is no model folder, it is set to [None]. As it is a list of length 1 we extract the first value with is None. As None is not of type str it goes into the else part, which failed.
There was a problem hiding this comment.
So it never got to this line here. This line is used, for example, in rasa test nlu where you can just have one model path (no list) and this check is working as expected.
Proposed changes:
Check if a model was provided when executing
rasa test core. If not, print a useful error message and stop.Status (please check what you already did):
black(please check Readme for instructions)