Update KafkaEventBroker to support SASL_SSL and PLAINTEXT protocols #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricwo
suggested changes
Oct 7, 2020
| # `_create_producer()` raises `kafka.errors.NoBrokersAvailable` exception | ||
| # which means that configuration seems correct but a connection to | ||
| # broker cannot be established | ||
| ("kafka_sasl_plaintext_endpoint.yml", kafka.errors.NoBrokersAvailable), |
There was a problem hiding this comment.
Optional: parametrize directly over the YAML strings instead of the filenames, and get rid of the files. I think it's a bit cleaner having the content in the test, especially for small files, but really this is up to you
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)