Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create correct KafkaProducer for PLAINTEXT and SASL_SSL security protocols. #7018

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Create correct KafkaProducer for PLAINTEXT and SASL_SSL security protocols. #7018

merged 4 commits into from
Oct 16, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Oct 15, 2020

Proposed changes:

  • update _create_producer function in kafka.py to create correct KafkaProducers

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx requested a review from wochinge October 15, 2020 07:53
wochinge
wochinge reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙌

  • Is this related to an open issue?
  • Can we please remove group_id from the KafkaEventBroker constructor as it doesn't make sense for an KafkaProducer
  • Can we add client_id to every KafkaProducer we create?

@alwx
Copy link
Contributor Author

alwx commented Oct 16, 2020

@wochinge no, it's not linked to any issue — we merged some updates to KafkaProducer about a week ago, and now we discovered that there is an issue with those updates.

@alwx alwx requested a review from wochinge October 16, 2020 09:45
wochinge
wochinge approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇
Can you please target 2.0.x instead of master?

@alwx alwx changed the base branch from master to 2.0.x October 16, 2020 10:11
@alwx alwx changed the base branch from 2.0.x to master October 16, 2020 10:11
@alwx alwx changed the base branch from master to 2.0.x October 16, 2020 10:50
@rasabot rasabot merged commit f7719c7 into 2.0.x Oct 16, 2020
@rasabot rasabot deleted the security-protocols-fix branch October 16, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alwx @wochinge @rasabot