Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack connector: implemented signing secret and updated docs #7186

Merged
merged 12 commits into from
Nov 8, 2020
Merged

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 5, 2020

Proposed changes:

  • validate slack requests using signing secret
  • updated documentation page (old instructions were outdated, added screenshots)
  • moved slack tests into their own module (added new tests for signature at the bottom)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested a review from a team as a code owner November 5, 2020 09:20
@tmbo tmbo requested review from joejuzl and removed request for a team November 5, 2020 09:20
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
@tmbo
Copy link
Member Author

tmbo commented Nov 5, 2020

@erohmensing added images to the slack docs, as it was very hard to follow them without. does this look sane?

@wochinge wochinge added this to the 2.1 Rasa Open Source milestone Nov 5, 2020
@tmbo tmbo changed the base branch from master to 2.0.x November 5, 2020 09:27
@tmbo tmbo changed the title implemented signing secret and updated docs slack connector: implemented signing secret and updated docs Nov 5, 2020
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the screenshots are very helpful!

docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
docs/docs/connectors/slack.mdx Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Show resolved Hide resolved
rasa/core/channels/slack.py Show resolved Hide resolved
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this 🚀
Left a couple of comments but nothing blocking 👍

rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Show resolved Hide resolved
tests/core/channels/test_slack.py Outdated Show resolved Hide resolved
tests/core/channels/test_slack.py Outdated Show resolved Hide resolved
tests/core/channels/test_slack.py Outdated Show resolved Hide resolved
tmbo and others added 2 commits November 6, 2020 14:32
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
@tmbo tmbo merged commit aec2763 into 2.0.x Nov 8, 2020
@tmbo tmbo deleted the slack-revamp branch November 8, 2020 15:31
@tmbo tmbo restored the slack-revamp branch November 8, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants