Simplify is_url function #7317
Merged
Simplify is_url function #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
approved these changes
Nov 20, 2020
| @@ -271,7 +271,8 @@ async def load_agent_on_start( | |||
| ) | |||
| except Exception as e: | |||
| rasa.shared.utils.io.raise_warning( | |||
| f"The model at '{model_path}' could not be loaded. " f"Error: {e}" | |||
| f"The model at '{model_path}' could not be loaded. " | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Change
is_urlso that it expects a somewhat reasonable URL and then check the schema/path/host. Useurllib.parseinstead of regexp.Fixes https://github.com/RasaHQ/rasa-x/issues/3881.
Status (please check what you already did):
black(please check Readme for instructions)