Merge resposnes from NLU and Domain when there're no retrieval intents #7390
Conversation
degiz
requested review from
Tawakalt
and removed request for
a team and
Tawakalt
degiz
force-pushed
the
fix_sync_of_responses
branch
2 times, most recently
from
6ae3b4f
to
5a0011c
Compare
degiz
force-pushed
the
fix_sync_of_responses
branch
from
5a0011c
to
5f0a1fb
Compare
| @@ -65,7 +65,6 @@ async def get_domain(self) -> Domain: | |||
| return domain | |||
| try: | |||
| domain = Domain.load(self._domain_path) | |||
| domain.check_missing_templates() | |||
There was a problem hiding this comment.
Shouldn't this check be done somewhere if not here?
There was a problem hiding this comment.
Question: Using the RetrievalModelDataImporter to achieve this without having any retrieval intents seems weird. Shouldn't the logic of syncing all responses defined in NLU data(irrespective of them being response templates for retrieval intents) be done inside CombinedDataImporter itself and then RetrievalModelDataImporter adds retrieval intents to domain and fetches the response templates from domain. What do you think?
|
@dakshvar22 I agree, that |
|
@degiz I also do not have very strong opinions but renaming it more appropriately(something like - |
|
@dakshvar22 I've change the name! Do you have time to re-review? |
Proposed changes:
responsesare synced between NLU data and the Domain even if there're no retrieval intents in the training data.Status (please check what you already did):
black(please check Readme for instructions)