Correctly set slots in domain when just updating nlg. #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghostvv
added
the
type:bug 🐛
joejuzl
force-pushed
the
7322/correctly_update_domain_if_no_ml_training
branch
from
45742c0
to
f1dc526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Domain.compare_with_specificationwas failing when runningrasa trainafter only changing NLG data. This is because the categorical slots were not having the default__other__value added when the domain was updated usingupdate_model_with_new_domain- so it ended up being inconsistent.Solution was to also set up the default slots in this method.
Status (please check what you already did):
black(please check Readme for instructions)