Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py36 drop: consider using asyncio.run instead of loop.run_until_complete() #9236

Closed
2 tasks
m-vdb opened this issue Jul 29, 2021 · 0 comments · Fixed by #9636
Closed
2 tasks

Py36 drop: consider using asyncio.run instead of loop.run_until_complete() #9236

m-vdb opened this issue Jul 29, 2021 · 0 comments · Fixed by #9636
Assignees
@usc-m
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Milestone
3.0 Rasa Open Source

Comments

@m-vdb
Copy link
Collaborator

m-vdb commented Jul 29, 2021 •
edited

Python 3.7 introduced asyncio.run:

This function always creates a new event loop and closes it at the end. It should be used as a main entry point for asyncio programs, and should ideally only be called once.

Definition of done

  • Evaluate if and where this should be replaced in the code
  • Implement needed changes
@m-vdb m-vdb added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 29, 2021
@m-vdb m-vdb added this to the 3.0 Rasa Open Source milestone Jul 29, 2021
@TyDunn TyDunn added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Sep 10, 2021
@usc-m usc-m mentioned this issue Sep 14, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usc-m usc-m

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
3.0 Rasa Open Source
Development

Successfully merging a pull request may close this issue.

Use asyncio.run instead of loop.run_until_complete RasaHQ/rasa
3 participants
@usc-m @m-vdb @TyDunn