Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding matrix dimension (page 519) #36

Closed
labdmitriy opened this issue Mar 22, 2022 · 2 comments
Closed

Embedding matrix dimension (page 519) #36

labdmitriy opened this issue Mar 22, 2022 · 2 comments

Comments

@labdmitriy
Copy link

Hi Sebastian,

There is the following statement on the page 519:
"The output will have the dimensionality batchsize × input_length × embedding_dim, where embedding_
dim is the size of the embedding features (here, set to 3). The other argument provided to
the embedding layer, num_embeddings, corresponds to the unique integer values that the model will
receive as input (for instance, n + 2, set here to 10). Therefore, the embedding matrix in this case has
the size 10×6."

Based on these conclusions, probably there is a typo in the last sentence and embedding matrix dimension is 10x3?

Thank you.

@rasbt
Copy link
Owner

rasbt commented Apr 13, 2022

Good catch. It even says 3 in the code 😅

Screen Shot 2022-04-13 at 6 27 02 PM

@rasbt
Copy link
Owner

rasbt commented Apr 13, 2022

Added it to the errata

@rasbt rasbt closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants