Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sklearn normalize depreciation fix #1036

Merged
merged 3 commits into from May 17, 2023

Conversation

namanmistry
Copy link
Contributor

Description

The new version of sklearn's LinearRegression does not allow normalize paramter which is depreciated in the newer versions. So I fixed that.

Related issues or pull requests

Fixes Arg normalize to sklearn.linear_model.LinearRegression has been removed in version 1.2 #1035

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a60f127) 77.27% compared to head (6279cc1) 77.27%.

❗ Current head 6279cc1 differs from pull request most recent head ea83ad6. Consider uploading reports for the commit ea83ad6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1036   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         200      200           
  Lines       11307    11307           
  Branches     1484     1484           
=======================================
  Hits         8737     8737           
  Misses       2351     2351           
  Partials      219      219           
Impacted Files Coverage Δ
...end/regressor/tests/test_stacking_cv_regression.py 95.78% <100.00%> (ø)
...lxtend/regressor/tests/test_stacking_regression.py 97.21% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rasbt
Copy link
Owner

rasbt commented May 17, 2023

Thanks for the PR, it looks good to me! Just moved the Changelog entry to the right section and fixed the small typo (depreciated -> deprecated)

@rasbt rasbt merged commit f14f4c6 into rasbt:master May 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants