Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use frozensets in apriori #394

Merged
merged 2 commits into from
Jun 16, 2018
Merged

use frozensets in apriori #394

merged 2 commits into from
Jun 16, 2018

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Jun 16, 2018

Description

Use frozensets instead of regular sets in mlxtend.frequent_patterns.apriori to improve selection efficiency

Related issues or pull requests

Just a minor improvement after #393

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

coveralls commented Jun 16, 2018

Coverage Status

Coverage increased (+0.04%) to 91.308% when pulling 203951f on frozenset into 84fde97 on master.

@rasbt rasbt merged commit 37a8ae8 into master Jun 16, 2018
@rasbt rasbt deleted the frozenset branch July 19, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants