Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_confusion_matrix inappropriate font color #586

Closed
sohrabtowfighi opened this issue Sep 12, 2019 · 6 comments
Closed

plot_confusion_matrix inappropriate font color #586

sohrabtowfighi opened this issue Sep 12, 2019 · 6 comments
Labels

Comments

@sohrabtowfighi
Copy link
Contributor

Thanks for your project.

I used plot_confusion_matrix using some of my data and came up with the following.

https://imgur.com/a/TdYChzg

Should not the bottom left square have black font?

@rasbt
Copy link
Owner

rasbt commented Sep 12, 2019

Yes, I agree. Black font would make more sense here.

This could be potentially related to #551 I think

@rasbt rasbt added the Bug label Sep 12, 2019
@sohrabtowfighi
Copy link
Contributor Author

I put in a pull request 588

@sohrabtowfighi
Copy link
Contributor Author

@rasbt
Copy link
Owner

rasbt commented Sep 15, 2019

I am a bit careful with zip files from the web. Could you just push the changes in the PR you opened? No worries if it is incomplete, I can take it from there

@sohrabtowfighi
Copy link
Contributor Author

done

@rasbt
Copy link
Owner

rasbt commented Sep 15, 2019

awesome thx! Will take of the PR then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants