Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward slection reduce mem copy #705

Merged
merged 3 commits into from Jul 14, 2020

Conversation

Saniamos
Copy link
Contributor

Description

Implements slicing the features from the data before copying it to the subprocess.

Related issues or pull requests

Fixes #704

Pull Request Checklist

  • [x ] Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • [ x] Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • [x ] Checked for style issues by running flake8 ./mlxtend

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.678% when pulling 0351253 on Saniamos:forward-slection-reduce-mem-copy into 6dfde8c on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Jul 14, 2020

Oh yeah, like you mentioned in #704, subprocesses require everything to be copied. You are right, we can slice the data before sending it to the processes. Thanks for implementing it!

@rasbt rasbt merged commit c928fd2 into rasbt:master Jul 14, 2020
@Saniamos
Copy link
Contributor Author

Oh yeah, like you mentioned in #704, subprocesses require everything to be copied. You are right, we can slice the data before sending it to the processes. Thanks for implementing it!

sure, thanks for the quick merge :-)

@Saniamos Saniamos deleted the forward-slection-reduce-mem-copy branch July 14, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of memory problem with sequential forward selection
3 participants