Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shebang lines in phamb python scripts #46

Closed
jmtsuji opened this issue Oct 11, 2022 · 2 comments
Closed

Update shebang lines in phamb python scripts #46

jmtsuji opened this issue Oct 11, 2022 · 2 comments

Comments

@jmtsuji
Copy link

jmtsuji commented Oct 11, 2022

Thanks for making this helpful viral binning tool! I have a minor request to improve the usability of the python scripts in the phamb directory, based on an issue I ran into while running the test data for phamb. See below:

Problem description

Using phamb 1.0.1, installed via conda on a linux server, I got the following error when running the test command:

Command:

phamb/run_RF.py test/contigs.fna.gz test/clusters.tsv test testout

Error:

phamb/run_RF.py: /usr/bin/python: bad interpreter: No such file or directory

Possible causes

I think the issue is caused by the shebang line in phamb/run_RF.py:

#!/usr/bin/python

Because I am running phamb in a conda env, my python is located in ${CONDA_PREFIX}/bin/python. I'm running a very clean system and don't have python installed globally.

Proposed solution

Change the shebang line of phamb/run_RF.py to a more universal shebang (discussed here):

#!/usr/bin/env python

Similarly, phamb/run_RF_modules.py and phamb/split_contigs.py could be changed to use the same shebang (they are currently using #!/bin/python).

I'm happy to make a PR for this minor change, if it helps. Thanks again!

@joacjo
Copy link
Collaborator

joacjo commented Oct 13, 2022

Hi Jackson

Thanks for reporting this and your suggestion. I tested your solution and it resolved the issue, so I will update the Master asap :) Please let me know if it's not working in your env.

Best,
Joachim

@jmtsuji
Copy link
Author

jmtsuji commented Oct 14, 2022

Thanks @joacjo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants