Refactor/modal #646
Closed
Refactor/modal #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename ReceiveOnChain to ReceiveAddress to refelct usage
escapedcat
force-pushed
the
refactor/modal
branch
from
8483587
to
aaa26b2
Compare
cstenglein
reviewed
Jul 30, 2023
cstenglein
reviewed
Jul 30, 2023
|
Will try to bring this to a presentable state first ;) |
escapedcat
force-pushed
the
refactor/modal
branch
from
bc58a3c
to
393d693
Compare
|
@cstenglein still just a draft, but could be applied to "all" modals. No rush, any feedback welcome. |
cstenglein
reviewed
Aug 6, 2023
|
|
||
| return createPortal( |
There was a problem hiding this comment.
the transition doesn't really work with a portal. need to google how to make it work
Co-authored-by: Christoph Stenglein <9399034+cstenglein@users.noreply.github.com>
Co-authored-by: Christoph Stenglein <9399034+cstenglein@users.noreply.github.com>
Co-authored-by: Christoph Stenglein <9399034+cstenglein@users.noreply.github.com>
Co-authored-by: Christoph Stenglein <9399034+cstenglein@users.noreply.github.com>
|
Will rework this. Not happy with it. Should be simpler. |
|
Learned some things. Will tackle this again after the UI has been updated or during the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413
First draft
Only took care of the receive modal for now to test this.
Happy for any feedback.
Screenshots
Open points
mastertoo