Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History is not preserved on modal open #52

Open
shining-mind opened this issue Jan 13, 2023 · 0 comments
Open

History is not preserved on modal open #52

shining-mind opened this issue Jan 13, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@shining-mind
Copy link
Member

Modals are opened by changing the route, which triggers re-render of the underlying page, which re-creates the viewport.

Some commands store layer list which is bound to the specific viewport instance. It means that commands can't be reused between different viewport instances.

We should be able to bind commands to the new viewport.

@shining-mind shining-mind added the bug Something isn't working label Jan 13, 2023
@shining-mind shining-mind self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant