Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the file descriptor, close the file on creation and hand out only the path #241

Closed
Tracked by #242
silkentrance opened this issue Feb 8, 2020 · 3 comments · May be fixed by #281
Closed
Tracked by #242

Get rid of the file descriptor, close the file on creation and hand out only the path #241

silkentrance opened this issue Feb 8, 2020 · 3 comments · May be fixed by #281
Milestone

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Feb 8, 2020

The file descriptor and the file that was opened by tmp has had some issues in the past, leading to a rather complex code base, including options such as discardDescriptor and detachDescriptor.

Getting rid of the file descriptor altogether seems to be a good solution that will eliminate a lot of rather complex code and which will also add to the overall stability of tmp.

This will be a breaking change that should be introduced with v0.3.0.

@silkentrance silkentrance mentioned this issue Feb 8, 2020
3 tasks
@silkentrance silkentrance added this to the 0.3.0 milestone Nov 25, 2020
@rijnhard
Copy link

related #267

@raszi
Copy link
Owner

raszi commented Feb 4, 2021

Good points and I agree to the proposal.

@silkentrance silkentrance linked a pull request Aug 29, 2022 that will close this issue
@silkentrance
Copy link
Collaborator Author

closing since the original maintainer shows no interest in this project anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants