Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect data conversion #205

Closed
seanLiu716 opened this issue Mar 14, 2023 · 2 comments
Closed

Incorrect data conversion #205

seanLiu716 opened this issue Mar 14, 2023 · 2 comments

Comments

@seanLiu716
Copy link

seanLiu716 commented Mar 14, 2023 •
edited
Loading

Python version

Please write here the output of printing sys.version
3.9

Platform information

Please write here the output of printing platform.platform()
Windows 11

Numpy version

Please write here the output of printing numpy.__version__

mdfreader version

Please write here the output of printing mdfreader.__version__
V4.1

Description

I read a signal (LMotSpd) with MDFReader V4.1.

yop.get_channel('LMotSpd')

Out[32]:
{'unit': 'rpm',
'description': ' Motor Present Speed\nºóÇý¶¯µç»úתËÙ·´À¡',
'master': 't_8_8',
'masterType': 0,
'data': array([24999, ..., 24999], dtype=uint16),

The data did not consider the offset of 25000.
The signal definition in CAN database is uint16, factor =1, offset = -25000.

So the first data point is -1 RPM, instead of 24999 RPM.

Commercial software, e.g. AVL Concerto, Vector CANalyzer can process the mdf file correctly.

Please fix the issue.

Thanks,
@max3-2 max3-2 mentioned this issue Mar 28, 2023
Open
@seanLiu716
Copy link
Author

Thanks @max3-2 for solving my problem.

@seanLiu716
Copy link
Author

Refer to #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanLiu716