Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor lints, making Clippy happier #189

Merged
merged 1 commit into from
May 22, 2023
Merged

Minor lints, making Clippy happier #189

merged 1 commit into from
May 22, 2023

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented May 21, 2023 •
edited

  • Default::default is hard to read
  • a few map -> map_or
  • simplified match -> let-if

@nyurik nyurik force-pushed the lint branch 3 times, most recently from 6b0d1cd to 17bdac6 Compare May 21, 2023 19:47
@nyurik
chore: Minor lints, making Clippy happier
6c5bd8d 
* `Default::default` is hard to read
* a few `map` -> `map_or`
* simplified `match` -> `let-if`

Signed-off-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
joshka
joshka approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (all changes reviewed)

@joshka joshka merged commit 3f9935b into ratatui-org:main May 22, 2023
7 checks passed
@joshka
Copy link
Member

joshka commented May 22, 2023

Merged. Thanks for your contributions

@nyurik nyurik deleted the lint branch May 22, 2023 05:31
@joshka joshka mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@sayanarijit sayanarijit sayanarijit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyurik @joshka @sayanarijit