Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Inline ViewPort to be resized #984

Open
PitiBouchon opened this issue Mar 12, 2024 · 3 comments
Open

Allow the Inline ViewPort to be resized #984

PitiBouchon opened this issue Mar 12, 2024 · 3 comments
Labels
Effort: Difficult This will take a lot of effort to change / fix Status: Design Needed An issue that isn't yet designed or specificied well enough to implement Type: Enhancement New feature or request

Comments

@PitiBouchon
Copy link

I would like to use the Viewport::Inline(height) and modify the height of it

I'm looking for :

  • Display one or more lines of modifiable text (e.g. docker compose up)
  • The number of lines of text will grow over time
  • ViewPort::Inline doesn't support the height changing

insert_before already works to print a line before the viewport but isn't modifiable

@PitiBouchon PitiBouchon added the Type: Enhancement New feature or request label Mar 12, 2024
@joshka joshka added Type: Enhancement Type: Enhancement New feature or request Status: Design Needed An issue that isn't yet designed or specificied well enough to implement Effort: Difficult This will take a lot of effort to change / fix and removed Type: Enhancement New feature or request Type: zEnhancement labels Jun 19, 2024
@joshka
Copy link
Member

joshka commented Jun 19, 2024

This seems like a reasonable feature to add. Would you mind putting some thoughts down on how the library might change to accommodate this (i.e. what methods will be added to the relevant types)? I wonder what would break if this was implemented.

@joshka joshka changed the title Possibility to modify height of inline viewport Allow the Inline ViewPort to be resized Jun 19, 2024
@PitiBouchon
Copy link
Author

I currently don't have much free time, but I'll look into it in the future

@joshka
Copy link
Member

joshka commented Jun 20, 2024

I currently don't have much free time, but I'll look into it in the future

No problem. Take as much time as you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Difficult This will take a lot of effort to change / fix Status: Design Needed An issue that isn't yet designed or specificied well enough to implement Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants