Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excercise 047 has mis-matched comment to code (mutable self) #126

Closed
ratfactor opened this issue Aug 19, 2022 · 1 comment
Closed

Excercise 047 has mis-matched comment to code (mutable self) #126

ratfactor opened this issue Aug 19, 2022 · 1 comment

Comments

@ratfactor
Copy link
Owner

Thanks to @unional for pointing out that the comment and code on Ex 047 do not match, which is super unfortunate. The comment shows an instance where we don't need a mutable reference. The code uses a self: *foo reference since it does need to be mutable.

There may be other instances where this has happened. Probably better check every instance of self in the Ziglings exercises to make sure this is being used consistently.

Re: #123

@hippietrail
Copy link

I know I was confused by the selfs in the exercises and was never sure whether I should've been using * or not. Maybe that was the result of it being inconsistent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants