Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new flag 'run_test' to support test steps for test exercises #278

Merged
merged 9 commits into from
May 13, 2023
Merged

Added new flag 'run_test' to support test steps for test exercises #278

merged 9 commits into from
May 13, 2023

Conversation

chrboesch
Copy link
Collaborator

Also created a simple exercise '102_testing' to test the new flag. After the new build system is ready, we skip the exercise in the flow to finish the actual testing exercise.
Regards: #277

Also created a simple exercise '102_testing' to test the new flag.
After the new build system is ready, we skip the exercise in the flow to finish the actual testing exercise.
@perillo
Copy link
Contributor

perillo commented May 5, 2023

I think you should add full support for testing, instead of first add a new `Exercisercise

Also created a simple exercise '102_testing' to test the new flag. After the new build system is ready, we skip the exercise in the flow to finish the actual testing exercise. Regards: #277

I think you should add full support for testing, instead of first adding a new Exercise field.

@chrboesch
Copy link
Collaborator Author

I think you should add full support for testing, instead of first adding a new Exercise field.

But why, we do not build productivity software, but just for learning purpose?

@perillo
Copy link
Contributor

perillo commented May 5, 2023

I think you should add full support for testing, instead of first adding a new Exercise field.

But why, we do not build productivity software, but just for learning purpose?

I think there is some misunderstanding here.

What I mean is that you should add a new field for testing an exercise (instead of running it) and update the code in ZiglingStep to actually spawn zig test exercise instead of zig build-exe exercise

@chrboesch
Copy link
Collaborator Author

chrboesch commented May 5, 2023

What I mean is that you should add a new field for testing an exercise (instead of running it) and update the code in ZiglingStep to actually spawn zig test exercise instead of zig build-exe exercise

Agree.

@perillo Would you like to program that?

@chrboesch chrboesch added the enhancement New feature or request label May 7, 2023
@chrboesch chrboesch merged commit c39ede2 into ratfactor:main May 13, 2023
11 checks passed
@chrboesch chrboesch deleted the testing branch May 13, 2023 21:31
vamega pushed a commit to vamega/ziglings that referenced this pull request Jul 25, 2023
Added new flag 'run_test' to support test steps for test exercises
fleimgruber pushed a commit to fleimgruber/ziglings that referenced this pull request Oct 26, 2023
Added new flag 'run_test' to support test steps for test exercises
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants