Skip to content

Commit

Permalink
Fixes #819
Browse files Browse the repository at this point in the history
* Resolves Tiger Cannon not reducing HP when max HP is out of variable bounds. Thanks to @CairoLee.
  • Loading branch information
aleos89 committed Dec 7, 2015
1 parent 0c9bd30 commit f7f1ec0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/map/skill.h
Expand Up @@ -115,9 +115,9 @@ enum e_skill_display {

/// Single skill requirement. !TODO: Cleanup the variable types
struct skill_condition {
int16 hp; ///< HP cost
int16 mhp; ///< Max HP to trigger
int16 sp; /// SP cost
uint16 hp; ///< HP cost
uint16 mhp; ///< Max HP to trigger
uint16 sp; /// SP cost
int16 hp_rate; /// HP cost (%)
int16 sp_rate; /// SP cost (%)
uint32 zeny; /// Zeny cost
Expand Down

2 comments on commit f7f1ec0

@CairoLee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @aleos89 , But uint16 max is 65,536

If player's MaxHp more then 220k, then this problem will reproduce again. so why not using uint32? XD

@cydh
Copy link
Contributor

@cydh cydh commented on f7f1ec0 Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right

Please sign in to comment.