-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Includes fixes for Dragon Combo, Fallen Empire, Tiger Cannon, and Sky Net Blow. * Removed the SR_FLASHCOMBO_ATK_STEP usage. * Fixes #627, fixes #725, fixes #741, and fixes #765. Thanks to @exneval and @rytech!
- Loading branch information
Showing
10 changed files
with
172 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -408,6 +408,7 @@ struct block_list { | |
int id; | ||
int16 m,x,y; | ||
enum bl_type type; | ||
int64 damage; | ||
}; | ||
|
||
|
||
|
Oops, something went wrong.
fc68007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really they (kRO) removed that _STEP skill?
when user mentioned no animation, is is confirmed? are u sure they don't use 'external' client files?
fc68007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've seen they don't use the _STEP stuff anymore because the ID clash with Doram skills. That's why I removed it.
fc68007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SR_FLASHCOMBO_ATK_STEP4 use same skill id Basic skill for Doram
fc68007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned it on Discord already, but I really would like to see a better solution than adding an int64 to block_list. At the very least only do it for renewal.
We just want the damage to be the same for all targets, right? Can't be just use skill_area_temp for this? Also, why do we have to move the damage code into skill.c? All damage code should be in battle.c.
fc68007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.