Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory and Cart save requests #1910

Closed
aleos89 opened this issue Jan 24, 2017 · 2 comments
Closed

Inventory and Cart save requests #1910

aleos89 opened this issue Jan 24, 2017 · 2 comments
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained

Comments

@aleos89
Copy link
Contributor

aleos89 commented Jan 24, 2017

  • rAthena Hash: 08d55d8

  • Client Date: Any

  • Server Mode: Both

  • Description of Issue:
    When a character is saved, a request is also sent for the inventory and cart data of that character. While this is good, not all instances of a player requesting to be saved needs their inventory and cart data to be saved as well. This results in a bit more server and network activity than what is needed.

  • Modifications that may affect results: None
@aleos89 aleos89 added component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained server:map labels Jan 24, 2017
@aleos89 aleos89 mentioned this issue Jan 24, 2017
Merged
@RadianFord
Copy link
Contributor

RadianFord commented Jan 27, 2017 •
edited

Sorry if im wrong about this, Is this related to the issue?
rathena

@aleos89
Copy link
Contributor Author

aleos89 commented Jan 27, 2017

Yes, exactly that.

@aleos89 aleos89 closed this as completed in d99c914 Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleos89 @RadianFord