Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobonus script (itemscript) #2612

Closed
ghost opened this issue Nov 19, 2017 · 10 comments
Closed

autobonus script (itemscript) #2612

ghost opened this issue Nov 19, 2017 · 10 comments
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:medium A fault that makes rAthena have significant repercussions but does not render rAthena unusable type:bug Issue that is a bug within rAthena

Comments

@ghost
Copy link

ghost commented Nov 19, 2017

  • Client Date: 20170125
  • Server Mode: Renewal
  • Description of Issue: itemscript autobonus giving unwanted result such as negative values or +/- values
    • Result: should be based on itemscript such as increase agi + 44 for autobonus
    • Expected Result: No negative values
    • How to Reproduce: Use autobonus itemscript to any items. Best example is in cards like Rudo Card.
  1. Equip Rudo Card to any boots slotted
  2. Equip boots
  3. Use @allstats
  4. Attach any monster melee or not. Skill or not.
  5. See status once card is activated.
  6. Value has negative value or sometimes +/- (see attached image)
    ss
  • Official Information: No links as of now.
  • Modifications that may affect results: none
@Jeybla
Copy link
Contributor

Jeybla commented Nov 19, 2017

Confirmed, even though it looks like it's just a display issue. Therefore I set it to priority low.

@Jeybla Jeybla added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained status:confirmed Issue that has been validated by a developer to affect rAthena type:bug Issue that is a bug within rAthena labels Nov 19, 2017
@ghost
Copy link
Author

ghost commented Nov 19, 2017

@Jeybla : Upon testing it's not a display issue only. But also status issue, cause from testing, my HP went from 230k to 113k due to the +/- status.

It got resolved or back to normal when I relogged. So if it is activated and received the negative value all calculations are affected.

@aleos89
Copy link
Contributor

aleos89 commented Nov 19, 2017

Probably somehow related to #2450?

@ghost
Copy link
Author

ghost commented Nov 19, 2017

@aleos89 : Will try to replicate the said item in #2450 with using autobonus script.

@ghost
Copy link
Author

ghost commented Nov 19, 2017

Tried #2450 , it's not giving negative values though.

@ghost
Copy link
Author

ghost commented Nov 25, 2017

@Jeybla @aleos89 just an update. I think all autobonus script in rA are having problems. Even with some enchants.

E.G. 4877,Speed_Of_Light,Speed of Light,6,10,,0,,,,,,,,,,,,,{ autobonus "{ bonus bAspdRate,100; bonus bFlee2,100; bonus2 bHPLossRate,400,1000; bonus2 bSPLossRate,40,1000; }",10,5000,BF_WEAPON,"{ specialeffect2 EF_FLASHER; callfunc "F_4877"; }"; },{},{ itemheal 0,-300; }

Once activated aspd dropped drastically.

It also happens in Hawk Eyes, some of the no cast skills have cast when it is activated.

@Jeybla
Copy link
Contributor

Jeybla commented Nov 25, 2017

Could be related to the compiler optimizations? @lighta

@ghost
Copy link
Author

ghost commented Nov 28, 2017

Which optimization is this? Is it available for pull request?

@Jeybla Jeybla added priority:medium A fault that makes rAthena have significant repercussions but does not render rAthena unusable and removed priority:low A fault that affects rAthena in one piece of functionality and is self-contained labels Nov 28, 2017
@secretdataz
Copy link
Member

Related: #131

@secretdataz
Copy link
Member

Closing this issue since autobonus is working fine as is. sc_start is the real culprit.
image

@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode priority:medium A fault that makes rAthena have significant repercussions but does not render rAthena unusable type:bug Issue that is a bug within rAthena
Projects
None yet
Development

No branches or pull requests

3 participants