BaseJob and Super Nono

[Atemo]

BaseJob NPC script command return the default value -1 for Super novice, super baby, super novice ex super baby ex class. I think in map.h

MAPID_SUPER_NOVICE = JOBL_SUPER_NOVICE|JOBL_2_1|0x0,
MAPID_SUPER_BABY = JOBL_SUPER_NOVICE|JOBL_BABY|JOBL_2_1|0x0,
MAPID_SUPER_NOVICE_E = JOBL_SUPER_NOVICE|JOBL_THIRD|JOBL_2_1|0x0,
MAPID_SUPER_BABY_E = JOBL_SUPER_NOVICE|JOBL_THIRD|JOBL_BABY|JOBL_2_1|0x0,

should be

MAPID_SUPER_NOVICE = JOBL_2_1|0x0,
MAPID_SUPER_BABY = JOBL_BABY|JOBL_2_1|0x0,
MAPID_SUPER_NOVICE_E = JOBL_THIRD|JOBL_2_1|0x0,
MAPID_SUPER_BABY_E = JOBL_THIRD|JOBL_BABY|JOBL_2_1|0x0,

[cydh]

the idea was we can do fast lookup for Sunov using bitwise &JOBL_SUPER_NOVICE
even it's MAPID_SUPER_NOVICE = JOBL_2_1|0x0
see on pc_readparam for SP_BASEJOB,

        case SP_BASEJOB:         val = pc_mapid2jobid(sd->class_&MAPID_UPPERMASK, sd->status.sex); break; //Base job, extracting upper type.

it masks every Sunov to 0x100. list not found on pc_mapid2jobid, tell me it's been like that since long time ago.

then what's BasJob of Super Novices? Novice? like this
https://gist.github.com/cydh/541bf46ba9d855e6835e

[Atemo]

Ha I get it

then what's BasJob of Super Novices? Novice? like this

The BaseJob should be Super nono for the 4 Super nono
JOB_SUPER_NOVICE

https://github.com/rathena/rathena/blob/master/src/map/map.h#L131

//Super Novices are considered the 2-1 version of the novice! Novices are considered a first class type, too...