Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Party Skills not working #390

Closed
LyndisRain opened this issue Apr 10, 2015 · 2 comments
Closed

Party Skills not working #390

LyndisRain opened this issue Apr 10, 2015 · 2 comments
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained

Comments

@LyndisRain
Copy link

Skills that target a party, only while in a party, no longer work as of today. It took me a while but I've discovered the problem in skill.c skill_area_sub. The fix for WM_VOICEOFSIREN & WM_LULLABY_DEEPSLEEP causes all skills that use this function (Angelus, Wind Walk, etc), to not work when they hit this part:
if (src == bl && !(flag&BCT_SELF))
return 0;
Because those skills don't have the BCT_SELF flag it just ends without doing anything, and there's no error because technically it's working properly. Commenting out those two lines fixes the problem, but brings back the original issue with WM_VOICEOFSIREN & WM_LULLABY_DEEPSLEEP.
@cydh cydh added status:confirmed Issue that has been validated by a developer to affect rAthena component:core A fault that lies within the main framework of rAthena [ status:started ] labels Apr 11, 2015
@cydh
Copy link
Contributor

cydh commented Apr 11, 2015

I did it wrong, I think better make new flag for BCT_WOS

@cydh cydh closed this as completed in 994aba6 Apr 11, 2015
@cydh
Copy link
Contributor

cydh commented Apr 11, 2015

thank you :D

@aleos89 aleos89 added priority:low A fault that affects rAthena in one piece of functionality and is self-contained server:map mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode and removed status:confirmed Issue that has been validated by a developer to affect rAthena labels Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aleos89 @cydh @LyndisRain