Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spirit Handler Skill Distribution issue #8030

Open
LadyNanuia opened this issue Dec 9, 2023 · 2 comments
Open

Spirit Handler Skill Distribution issue #8030

LadyNanuia opened this issue Dec 9, 2023 · 2 comments
Labels
type:bug Issue that is a bug within rAthena

Comments

@LadyNanuia
Copy link

rAthena Hash

28897cc

Client Date

2021-11-03

Server Mode

Renewal

Result

So i added Spirit handler using the PR #7998 which added the skills in a workable state if you did @allskills with a GM, however if you changed job from Summoner to Spirit handler, you wouldnt be able to get the skills unless you maxed out ALL SUMMONER skills, i used this #7069 to try and fix the issue, which it did but now after a server reboot, the Spirit handlers can no longer use their Spirit handler tree and if they put skill points into Summoner Tree, it vanishes upon relogging

Relevant Log Output

None

Expected Result

For spirit handlers to be able to skill their skills and not lose them when they relogg (possible Database issue with Spirit handler class?)

How to Reproduce

use the PR's i listed above and then make a Summoner, level it to 200/60, change to spirit handler, get some job levels, put points into Spirit handler skills, then relog / reboot server.

Official Information

Skill point distribution should stick like other classes.

Modifications that may affect results

None

@LadyNanuia LadyNanuia added the type:bug Issue that is a bug within rAthena label Dec 9, 2023
@asydia
Copy link

asydia commented Dec 17, 2023

merged PR #7998, got the issue of not being able to pick spirit handler skills unless all summoner skills maxed
merged #7069 into #7998, fixes the initial issue, can't seem to reproduce your bug @LadyNanuia, everything seems to work well. leveled multiple dorams and gave them spirit handler skills, rebooted server, relogged characters, all their skills are still there

@Nicapone1
Copy link

Change : MAPID_SPIRIT_HANDLER = JOBL_UPPER|MAPID_SUMMONER,
To : MAPID_SPIRIT_HANDLER = JOBL_FOURTH|JOBL_THIRD|JOBL_UPPER|JOBL_2_1|MAPID_SUMMONER,

src/map/map.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Issue that is a bug within rAthena
Projects
None yet
Development

No branches or pull requests

3 participants