Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notation rc-1 support #274

Closed
2 tasks done
dtzar opened this issue Aug 1, 2022 · 4 comments · Fixed by #433
Closed
2 tasks done

Add notation rc-1 support #274

dtzar opened this issue Aug 1, 2022 · 4 comments · Fixed by #433
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dtzar
Copy link
Contributor

dtzar commented Aug 1, 2022

This notably includes a new directory and trust store which should work with ratify. Will update this issue with more details later. This should be done before #147

Specific features which will be added as a result:

@dtzar dtzar added the enhancement New feature or request label Aug 1, 2022
@dtzar dtzar added this to the v1.0.0-beta milestone Aug 1, 2022
@etrexel
Copy link
Contributor

etrexel commented Sep 14, 2022

The notation-go v0.10.0-alpha.3 update still provides the original Verifier struct that we are using now with a modest change to handling trusted certs, but the new Verifier struct that includes support for TrustPolicy is a substantial shift from the previous implementation.

The new Verify function accepts an artifactUri string for verification and performs all of the signature artifact retrieval internally via a new notation Repository interface which will require us to implement a shim for our referrerstore. This internal retrieval looks for all notaryv2 signatures attached to the provided artifactUri which further breaks our model of handling individual artifacts within the executor.

There are a couple options that we can explore:

  • Work with the notation project to refactor some of the currently module-scoped implementation into notation-core-go so that we can use it without having to add shims to our existing model
  • Implement shims to utilize notation-go as-is
  • Replicate some of the private functionality from notatation-go directly in the ratify notaryv2 verifier

@dtzar
Copy link
Contributor Author

dtzar commented Sep 14, 2022

Per the community call today, @etrexel is going to file an issue to notation-go to propose changes which would help us implement (2nd/3rd bullets). notation-core-go is designed to be only core crypto and utilized by notation-go, so 1st bullet likely wouldn't fly.

@etrexel
Copy link
Contributor

etrexel commented Sep 14, 2022

See link above for issue in notation-go.

@dtzar dtzar changed the title Add notation alpha-3 support Add notation rc-1 support Sep 20, 2022
@dtzar dtzar modified the milestones: v1.0.0-beta.1, V1.0.0-beta.2 Sep 20, 2022
@sajayantony
Copy link
Contributor

Does this issue also cover the work to move to Trust policy or is there another item tracking the work for trust policy include updating docs for this one /cc @binbin-li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants