Groovy Extensions for RxJava and Reactive Streams

[danveloper]

Groovy extensions provide the ability to add instance-level "helper" methods to different types. We can use this to make the translation from Observable and Publisher to Promise (and vice-versa) a more-seamless integration for Groovy-based applications.

[danveloper]

resolved via fb9286e

[ldaley]

Where did we land on the version attribute?

[ldaley]

Also, needs a milestone set before closing.

[danveloper]

@melix informs that the moduleVersion field is simply used for reporting purposes. In our case, it seems rather unlikely that an application would pull in two of the same ratpack-core/rx jars, so I'm not convinced that we really need it at all. (It works fine without it defined.)

[davidmc24]

Really? I thought it refused to use the module if the moduleVersion wasn't defined.

https://github.com/groovy/groovy-core/blob/0b2182bff2250150e69ccb988f367e709b4560de/src/main/org/codehaus/groovy/runtime/m12n/MetaInfExtensionModule.java#L62

[melix]

Yes, sorry @danveloper if it wasn't clear: the descriptor and version is required. Groovy will complain if it finds two versions of the same module on classpath.

[danveloper]

It does work without it, though: https://github.com/ratpack/ratpack/blob/master/ratpack-rx/src/test/groovy/ratpack/rx/RxAsPromiseSpec.groovy#L49

[davidmc24]

Ah, empty string vs. null.

https://github.com/ratpack/ratpack/blob/master/ratpack-rx/src/main/resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule#L2

[danveloper]

Good point -- I should have noted that the field is present, but not assigned. We can assign a dummy value if it makes it easier to understand. Thoughts?

[johnrengelman]

Might as well call it 1.0.0 since it's our first version. Then if we ever change it, we can up the number.

[ldaley]

I'm not as across the details as you guys, but just hardcoding 1.0.0 seems reasonable to me.