Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning on crazy model/data values, and print min/max #383

Open
o-smirnov opened this issue May 24, 2020 · 0 comments
Open

add warning on crazy model/data values, and print min/max #383

o-smirnov opened this issue May 24, 2020 · 0 comments

Comments

@o-smirnov
Copy link
Collaborator

@KshitijT ran into a crazy MODEL_DATA column. He's not the first one and he won't be the last, and it's not a CubiCal problem per se, but the resulting behaviour is "why is my solver acting funny", and it can be tricky to diagnose quickly.

Suggest adding a debug-print statement (at level 1 or 2) to the solver with the min/max/mean data and model amplitudes. That way crazy inputs will be easy to spot.

We could even add a warning message. But what's the threshold for "crazy" data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant