Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to bomb out when null model is detected #438

Open
o-smirnov opened this issue Mar 3, 2021 · 2 comments
Open

add option to bomb out when null model is detected #438

o-smirnov opened this issue Mar 3, 2021 · 2 comments
Assignees

Comments

@o-smirnov
Copy link
Collaborator

Model columns can't be null. They're only null when (a) casacore/python-casacore#130 has its teeth in you, or (b) WSClean/DDFacet did not fill in the model properly (possibly because you had too many flags on the MS when predicting).

Both cases are Very Bad News actually, so I think the red warning should be upgraded to an exception.

(Or maybe add a parset option to throw an exception or not? Default being to throw.)

@o-smirnov o-smirnov self-assigned this Mar 3, 2021
@cyriltasse
Copy link
Collaborator

or (c) when the sky itself is empty... :))

@o-smirnov
Copy link
Collaborator Author

or (c) when the sky itself is empty... :))

Which is also an excellent reason to stop calibrating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants