Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode UTF8 chars in document names #11

Closed
raucao opened this issue Apr 12, 2018 · 3 comments
Closed

Encode UTF8 chars in document names #11

raucao opened this issue Apr 12, 2018 · 3 comments
Labels

Comments

@raucao
Copy link
Owner

raucao commented Apr 12, 2018

Currently, it does the wrong requests with unencoded characters.

@raucao raucao added the bug label Apr 12, 2018
@gregkare
Copy link

Right now the "é" (e with acute accent) is sent by rs-backup as \xE9 as part of a URL. The RS.js library encodes that as \xC3\xA9 when performing the PUT request, which is valid hex encoded UTF-8 (https://unicode-table.com/en/00E9/)

Typing "\xE9" in a node REPL results in the e with acute accent character, but that doesn't appear to be a valid encoded version of the U+00E9 unicode character

@gregkare
Copy link

Request from rs-backup: /gk-test-2018-04-12/myfavoritedrinks/bois-band\xE9
Request from myfavoritedrinks: /gk-test-2018-04-12/myfavoritedrinks/bois-band\xC3\xA9

@gregkare
Copy link

And there's a site using the utf8 npm module to encode/decode utf8: https://mothereff.in/utf-8#%C3%A9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants