Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Setting: "Hide Gift button" doesnt seem to work. #559

Closed
Marfjeh opened this issue Feb 13, 2021 · 8 comments
Closed

[Bug] Setting: "Hide Gift button" doesnt seem to work. #559

Marfjeh opened this issue Feb 13, 2021 · 8 comments

Comments

@Marfjeh
Copy link

Marfjeh commented Feb 13, 2021

Describe the Bug
In settings there is an option for Hide Gift button doesn't seem to work.

To Reproduce
Open settings > BetterDiscord > Settings > Hide gift button. enable it.
Then go back, to a text channel.

Expected Behavior
After toggling Hide gift button the button should be gone in the text area.

Screenshots
image
image

Discord Version
Stable.
I'm using the beta version of BD. only version string I could find is below here.

Stable 76771 (f5e89dd)
BD 1.0.0 (086482f)
Host 0.0.13
Injector 0.6.2
Linux 64-Bit (5.9.16-1-MANJARO)

Additional Context
I have enabled those settings in betterdiscord:
(Apperance)

  • 24-hour Timestamps
  • Hide gift button
  • Minimal Mode
  • Dark Mode
@Marfjeh Marfjeh added the bug label Feb 13, 2021
@Marfjeh
Copy link
Author

Marfjeh commented Feb 13, 2021

You can however select the button with:

Forexample in JS

document.querySelector("#app-mount > div.app-1q1i1E.da-app > div > div.layers-3iHuyZ.da-layers.layers-3q14ss > div > div > div > div > div.chat-3bRxxu.da-chat > div > main > form > div > div > div > div > div > div.buttons-3JBrkn.da-buttons > button")

so probably discord may changed the classes for the text area buttons?

@Strencher
Copy link
Member

Strencher commented Feb 13, 2021

Yes, discord updated their textarea recently which broke that setting. Please be patient about fixes.

Also: We didn't use classNames for that, we patched the react component and removed that children.

@Marfjeh
Copy link
Author

Marfjeh commented Feb 15, 2021

Alrighty.

@shinji257
Copy link

I'm just going to note that the Show GIF option is also affected but likely due to the same reason.

@Strencher
Copy link
Member

Yes, maybe the next updates includes a fix for both settings.

@rauenzi
Copy link
Member

rauenzi commented Apr 20, 2021

This has been fixed in the latest update.

@rauenzi rauenzi closed this as completed Apr 20, 2021
@cmd430
Copy link

cmd430 commented May 11, 2021

This has broken again with the latest Discord update

@programmer2514
Copy link

As a workaround until it's fixed, adding this to your custom CSS should hide both buttons:

/* Hides the gift button */
[aria-label="Send a gift"] {
    display: none;
}

/* Hides the GIF button */
[aria-label="Open GIF picker"] {
    display: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants