Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #97

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • This package requires php-5.3 version at least, it should add php-5.3 version to php-7.4 version tests on Travis CI build.
  • Let composer install --prefer-dist be good enough to install dependencies on Travis CI build executing.
  • Split the "Sepia\\Test\\": "tests/" from autoload block and add it to autoload-dev block.
  • Add EOF (end of file) on phpunit.xml file.

@@ -27,11 +27,15 @@
"require-dev": {
"squizlabs/php_codesniffer": "^2.0",
"fzaninotto/faker": "^1.7",
"phpunit/phpunit": "^4.0"
"phpunit/phpunit": "^4.8.36"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHPUnit\Framework\TestCase class has supported since the phpunit-4.8.36 version.

@pherrymason
Copy link
Owner

This package requires php-5.3 version at least, it should add php-5.3 version to php-7.4 version tests on Travis CI build

My lasts builds were broken in that version, that's why it was removed. If it's fixed now then perfect.

@pherrymason pherrymason merged commit da3582d into pherrymason:master Mar 9, 2020
@peter279k peter279k deleted the test_enhancement branch March 9, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants