Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Composer filesystem port #24

Open
raulfraile opened this issue Jun 25, 2015 · 4 comments
Open

Remove Composer filesystem port #24

raulfraile opened this issue Jun 25, 2015 · 4 comments

Comments

@raulfraile
Copy link
Owner

Currently, Distill uses a port of Composer's filesystem to get around rename issue: #9

I'm considering removing the port and use the Symfony Filesystem component in next version, but unfortunately the issue symfony/symfony#12533 is not fixed yet. Any comments @weaverryan @javiereguiluz @xabbuh?

@weaverryan
Copy link
Contributor

@raulfraile What's your motivation for removing the port? That would basically re-open issue #9 as well, right?

@raulfraile
Copy link
Owner Author

@weaverryan yeah, that's why I don't want to remove it until symfony/symfony#12533 is fixed. As you pointed out in the PR, this was a temporary fix, and I would like to just rely on the Symfony Filesystem in the next major version.

@weaverryan
Copy link
Contributor

It doesn't look like there's even a PR for symfony/symfony#12533. Obviously, the best-case scenario would be to make that PR with the fix, then happily remove the port from here :).

@xabbuh
Copy link
Contributor

xabbuh commented Jun 25, 2015

I still have the issue on my to do list. I can try to fix it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants