Fix multiple actions when using redux saga #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt from the previous action
rgommezz
requested changes
Dec 21, 2018
There was a problem hiding this comment.
Hi @Norris1z, many thanks for the PR!
Looks good, just some nits to address before getting it merged.
Also, could you please remove package-lock.json? I use Yarn as the official Node package manager, so only yarn.lock files should be committed
Norris1z
force-pushed
the
fire_action_for_unique_connection_changes
branch
from
3962f82
to
b1a638e
Compare
Norris1z
added a commit
to Norris1z/react-native-offline
that referenced
this pull request
Dec 24, 2018
When using this library with redux saga, the action: `@@network-connectivity/CONNECTION_CHANGE` seems to be fired even when the `internetConnection` state is the same as the `previousState`. This pull request fixes rgommezz#119 This pull request if merged will fire connection change action only when the current action is different from the previous action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library with redux saga, the action:
@@network-connectivity/CONNECTION_CHANGEseems to be fired even when theinternetConnectionstate is the same as thepreviousState.This pull request is related to issue #119
This pull request if merged will fire connection change action only when the current action is different from the previous action