Add example app #138
Add example app #138
Conversation
When using this library with redux saga, the action: `@@network-connectivity/CONNECTION_CHANGE` seems to be fired even when the `internetConnection` state is the same as the `previousState`. This pull request fixes rgommezz#119 This pull request if merged will fire connection change action only when the current action is different from the previous action
Norris1z
force-pushed
the
add_example_app
branch
from
303da2a
to
a89681b
Compare
|
This will also solve #118 |
|
Hey @Norris1z, I have mixed feelings about this PR. On one side, I appreciate the effort of creating an example application that showcases how to use the library in practise. It's clearly one of the important things missing in this repository and that's great for the library itself. But on the other side, a PR like this size and nature has to be consulted beforehand with the library owner. I don't know if you've read the contributing guide, but I recommend you do every time you plan to contribute to some other OSS library from now on, in order to not waste anyone's precious time, most importantly yours. Now, being that said, one of the problems with this PR is that it's been developed while I was working on the next major release of the library, that has re-structured the whole repository organisation and introduced several breaking changes, with a brand new API, therefore making some of your examples stale. In addition to that, a work of this nature is probably better fit for the library owner. I feel the examples are too basic and some of the code is already reflected as snippets in the README.md. Besides making your I am truly sorry, but I am afraid I can't merge this. I really hope this won't happen again in your OSS experience, nor changing your desire of keeping contributing. |
This pr adds demo apps which guides users on how to use this package with and without redux.
This pr if merged will solve issues #21