Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: checkInternetConnection, configure method type #264

Merged
merged 2 commits into from Apr 8, 2020
Merged

add: checkInternetConnection, configure method type #264

merged 2 commits into from Apr 8, 2020

Conversation

1ike
Copy link
Contributor

@1ike 1ike commented Apr 3, 2020 •
edited by rgommezz

…nection

Motivation

Fixes #263

When I try check my server availability as the first action (example from readme) using checkInternetConnection I can specify only url and timeout. But my server give status 200 only with OPTIONS method, with default HEAD it send 403. We can specify method for provider and context but can't for checkInternetConnection.

Test plan

Test adapted to additional argument.

Code formatting

Code was linted and prettiered (for example folder I reverted changes after prettier).

@1ike 1ike mentioned this pull request Apr 3, 2020
Closed
rgommezz
rgommezz approved these changes Apr 8, 2020
View reviewed changes
Copy link
Owner

@rgommezz rgommezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

@rgommezz rgommezz changed the title add possibility to specify method as 4th argument in checkInternetCon… add: checkInternetConnection, configure method type Apr 8, 2020
@rgommezz rgommezz merged commit 8a6a4a7 into rgommezz:master Apr 8, 2020
@rgommezz
Copy link
Owner

rgommezz commented Apr 8, 2020

@all-contributors please add @1ike for code

@allcontributors allcontributors bot mentioned this pull request Apr 8, 2020
Merged
@allcontributors
Copy link
Contributor

@rgommezz

I've put up a pull request to add @1ike! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommezz rgommezz rgommezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "method" argument to the checkInternetConnection utility.
2 participants
@1ike @rgommezz