Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export context #304

Conversation

sbelzile-nexapp
Copy link

Please provide enough information so that others can review your pull request:

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?

I would like to have some kind of hook useNetworkReachable(). Exporting the context allows me to do this. I was wondering if there was any reason why it's not already exported?

Test plan

Demonstrate the code is solid and make sure you add tests to cover the new functionality.

The code must pass tests. It's an export...

Code formatting

Look around. Match the style of the rest of the codebase. Run yarn format before committing.

@rgommezz
Copy link
Owner

Hey @sbelzile-nexapp,

Thanks for your contribution. I thought it was easier to provide the hook out of the box, as well as proper docs. I'll ship a new version in the next minutes.

@all-contributors please add @sbelzile-nexapp for ideas

@allcontributors
Copy link
Contributor

@rgommezz

I've put up a pull request to add @sbelzile-nexapp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants