Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: The destructuring algorithm #3

Open
rauschma opened this issue Dec 6, 2019 · 3 comments
Open

Chapter: The destructuring algorithm #3

rauschma opened this issue Dec 6, 2019 · 3 comments

Comments

@rauschma
Copy link
Owner

rauschma commented Dec 6, 2019

No description provided.

@bendtherules
Copy link

bendtherules commented Aug 22, 2020

I felt that this chapter was overly complicated and very limited in scope.

  1. The grammar syntax used to explain matching seems complicated and vague. Is it a common/standard syntax? It didn't look like the one used in spec.

  2. I probably shouldn't complain about this, because it's upto the author - but this chapter seems to just answer once question about destructuring? To me, it seems that there are a lot of interesting details about destructuring that could have been covered - like rest uses ownProps, stores excludedList of properties, etc.

Sorry for opening a issue just to criticize, but I liked the previous chapter on coercion very much and something about this chapter felt off. It felt bit incomplete or like a draft.

@rauschma
Copy link
Owner Author

@bendtherules I definitely appreciate this kind of high-level feedback!

The chapters do indeed vary considerably in character and scope. In my experience, different readers like different chapters.

@LiuuY
Copy link

LiuuY commented Jun 10, 2021

At the bottom of Section 3.1.2

throw new TypeError(); should be formatted as code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants