Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: Asynchronous iteration #1

Open
rauschma opened this issue Feb 13, 2018 · 9 comments
Open

Chapter: Asynchronous iteration #1

rauschma opened this issue Feb 13, 2018 · 9 comments

Comments

@rauschma
Copy link
Owner

No description provided.

@vsemozhetbyt
Copy link

Re: "Example: reading text lines asynchronously".

It seems readline module can simplify implementation so that splitLines() step can be eliminated. See an example:

https://nodejs.org/api/readline.html#readline_example_read_file_stream_line_by_line

@vsemozhetbyt
Copy link

Possible typos:

  1. "It’s implementation is relatively complex...": It’s -> Its?
  2. "Channels feels like a good abstraction...": feels -> feel?

@philipjc-apacio
Copy link

Hello, and thank you for the book. Sorry if this question is not relevant here. Can we test these features out yet, does babel have a 2019 preset?

@Zearin
Copy link

Zearin commented Jun 24, 2018

@rauschma Was gonna report a typo, but @vsemozhetbyt already beat me to it. ☻

Your writing is fantastic, and outshines almost everything else on cutting-edge Javascript I can find. Thank you so much!

@rauschma
Copy link
Owner Author

rauschma commented Jun 24, 2018

@vsemozhetbyt @Zearin Thanks! The typos will be fixed in the next release.

@rauschma
Copy link
Owner Author

@vsemozhetbyt Regarding your other two comments:

  1. I wanted to explicitly show how normal callback-based reading of data works in Node.js, so the example is deliberately more complicated than it needs to be.
  2. Links: will be fixed in the next release, thanks!

@semmel
Copy link

semmel commented Mar 26, 2019

Please provide the link to the AsyncQueue implementation in section 5.4.3.
https://github.com/rauschma/async-iter-demo/blob/master/src/async_iter_tools.js

I had a hard time wondering what "example repo" you mean, finally finding it in the according blog post.

Otherwise thank you for the enjoyable book!

@atengberg
Copy link

atengberg commented Mar 18, 2024

I only bring this up because of how consistently clear and helpful the rest of this and your other books are, but there is a missing comma separating the method properties next() and _run() of the object literal showing "a rough approximation of how async generators work" in 5.3.2. await in async generators. Really this is just a reason to say thank you--wish I had found these books when I first started (even made it possible for me to write this comment correctly)!

*While this isn't in the newer editions, examples like these I found helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants