Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: Asynchronous iteration #1

Open
rauschma opened this Issue Feb 13, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@rauschma
Copy link
Owner

rauschma commented Feb 13, 2018

No description provided.

@vsemozhetbyt

This comment has been minimized.

Copy link

vsemozhetbyt commented Mar 2, 2018

Re: "Example: reading text lines asynchronously".

It seems readline module can simplify implementation so that splitLines() step can be eliminated. See an example:

https://nodejs.org/api/readline.html#readline_example_read_file_stream_line_by_line

@vsemozhetbyt

This comment has been minimized.

Copy link

vsemozhetbyt commented Mar 4, 2018

Possible typos:

  1. "It’s implementation is relatively complex...": It’s -> Its?
  2. "Channels feels like a good abstraction...": feels -> feel?
@philipjc-apacio

This comment has been minimized.

Copy link

philipjc-apacio commented Mar 5, 2018

Hello, and thank you for the book. Sorry if this question is not relevant here. Can we test these features out yet, does babel have a 2019 preset?

@Zearin

This comment has been minimized.

Copy link

Zearin commented Jun 24, 2018

@rauschma Was gonna report a typo, but @vsemozhetbyt already beat me to it. ☻

Your writing is fantastic, and outshines almost everything else on cutting-edge Javascript I can find. Thank you so much!

@rauschma

This comment has been minimized.

Copy link
Owner Author

rauschma commented Jun 24, 2018

@vsemozhetbyt @Zearin Thanks! The typos will be fixed in the next release.

@rauschma

This comment has been minimized.

Copy link
Owner Author

rauschma commented Jun 24, 2018

@vsemozhetbyt Regarding your other two comments:

  1. I wanted to explicitly show how normal callback-based reading of data works in Node.js, so the example is deliberately more complicated than it needs to be.
  2. Links: will be fixed in the next release, thanks!
@semmel

This comment has been minimized.

Copy link

semmel commented Mar 26, 2019

Please provide the link to the AsyncQueue implementation in section 5.4.3.
https://github.com/rauschma/async-iter-demo/blob/master/src/async_iter_tools.js

I had a hard time wondering what "example repo" you mean, finally finding it in the according blog post.

Otherwise thank you for the enjoyable book!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.