Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: Asynchronous programming in JavaScript #26

Open
rauschma opened this issue Jul 19, 2018 · 5 comments
Open

Chapter: Asynchronous programming in JavaScript #26

rauschma opened this issue Jul 19, 2018 · 5 comments

Comments

@rauschma
Copy link
Owner

No description provided.

@AndiPersti
Copy link

39.1.3 Callback-based asynchronous functions :

In the code snippet the second parameter of the callback is named result. But later on in the text, the parameter is called r:

A result r: Then the following task is added to the queue.
taskQueue.enqueue(() => callback(null, r));

I'd suggest to use result in both places.

@rauschma
Copy link
Owner Author

rauschma commented Jan 2, 2022

@AndiPersti True, thanks! Fixed in next release.

@0fye
Copy link

0fye commented Apr 4, 2022

In 39.2 "The call stack" section:

https://exploringjs.com/impatient-js/ch_async-js.html#the-call-stack

Error.prototype.stack is non-standard:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Stack

It's implemented in all platforms though. Maybe mention this fact a little bit?

@rauschma
Copy link
Owner Author

rauschma commented Apr 4, 2022

@0fye
Copy link

0fye commented Apr 4, 2022

Ahh nice, thanks!!! @rauschma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants