Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: Classes #19

Open
rauschma opened this issue Jul 12, 2018 · 8 comments
Open

Chapter: Classes #19

rauschma opened this issue Jul 12, 2018 · 8 comments

Comments

@rauschma
Copy link
Owner

No description provided.

@rightpad
Copy link

Minor typo in section 24.2.3:

The name of property .prototype is not ideal: Person.prototype does not point the to the prototype of Person, it points to the prototype of all instances of Person.

@MignonBelongie
Copy link

26.2.3.1: haven’t look looked at
26.4.4: via a function

@rauschma
Copy link
Owner Author

@Da-moo Fixed now, thanks!

@rauschma
Copy link
Owner Author

@MignonBelongie Will be fixed in the next release, thanks!

@wgmyers
Copy link

wgmyers commented Oct 1, 2020

Secret bonus exercise not mentioned in text?

If that was intentional, I will happily delete this comment.

@ricgonmen
Copy link

Just a minor issue. In the text "It is interesting to note that both constructs inside class Person (.constructor and .describe()) created properties for Person.prototype, not for Person.", would it be more correct to say "It is interesting to note that both methods inside class Person (.constructor and .describe()) created properties for Person.prototype, not for Person."?.

Thanks @rauschma for this ussefull and clear manual on Javascript, so far the best I have found.

@rauschma rauschma changed the title Chapter: Prototype chains and classes Chapter: Classes Dec 15, 2021
@rauschma
Copy link
Owner Author

@ricgonmen .constructor() isn’t really a method (it’s more). That’s why I didn’t call it a method here.

@rauschma
Copy link
Owner Author

rauschma commented Jan 1, 2022

@pdspx Fixed in next release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants